Hidetoshi NAGAI wrote:
> Thank you for your patch. I have some questions.
> 
> * Which version of Tile extension is your patch based on?
).7.6, which seems to be the latest.
> 
> * [about Tk::Tile::TNotebook#tab]
>   There are Tk::Tile::TNotebook#tabconfigure, tabconfiginfo, tabcget,
>   and current_tabconfiginfo (similar as item configuration strategy on
>   other widgets). Aren't those enough?
Umm, I guess I missed those. If they work the same then that's fine.
> 
> * [about Tk::Tile::TNotebook#select]
>   How about adding new method "Tk::Tile::TNotebook#selected"?
>   -------------------------------------------
>     class Tk::Tile::TNotebook
>       def selected
>          num_or_str(tk_send_without_enc('select'))
>       end
>     end
That's fine too, I was just keeping the API the same as in the tile 
documentation.
>   -------------------------------------------
> 
> * [about Tk::Tile::Treeview#insert]
>   Is the following OK?
>   -------------------------------------------
>     class Tk::Tile::Treeview
>       def insert(parent, idx, keys={})
>         keys = _symbolkey2str(keys)
>         id = keys.delete('id')
>         if id
>           num_or_str(tk_send('insert', parent, idx, '-id', id, 
> *hash_kv(keys)))
>         else
>           num_or_str(tk_send('insert', parent, idx, *hash_kv(keys)))
>         end
>       end
>     end
>   -------------------------------------------
Again looks fine to me. I'll test them all out and let you know.

Many thanks,

Andrew


-- 
Posted via http://www.ruby-forum.com/.