On Tue, Sep 05, 2006 at 10:53:42AM +0900, John Carter wrote:
> On Tue, 5 Sep 2006, Mauricio Fernandez wrote:
> 
> >On Fri, Sep 01, 2006 at 02:16:58PM +0900, John Carter wrote:
> >>Is it my fevered imagination, or has Ruby-1.8.5 clobbered rcov-0.7.0,
> >>causing it to segfault.
> 
> >This code was mostly taken from eval.c's backtrace(). It was changed on
> >Jul 24, but the modification doesn't seem to imply that the above would
> >segfault under 1.8.5. At any rate, here's the patch to mirror the new
> >backtrace():
> >
> >
> >diff -rN -u old-head/ext/rcovrt/rcovrt.c new-head/ext/rcovrt/rcovrt.c
> 
> Yip. That fixed it!

That's good news but I'd have liked to understand why :)

I'll apply that patch for the next release; probably compiling it
conditionally. While it looks like it should work with <1.8.5, I'm obviously
missing something because I don't quite see why it fixed the segfault you
reported :) (iow. I have yet to find the modification that allowed
frame->node to hold invalid pointers).

-- 
Mauricio Fernandez  -   http://eigenclass.org   -  singular Ruby