Issue #13563 has been updated by saturnflyer (Jim Gay).


babanba-n (matzbara masanao) wrote:
> I feel that Hash#slice is wrong name and Hash#pick is better name. 
> If key is not exist, key omit or return nil.
> It is difficult problem. 

I prefer Hash#pick over Hash#choice.

I would expect the missing keys to return whatever the default value of the hash is.

~~~ ruby
hash = Hash.new('foo')
hash[:bar] = 'hello world'

hash.pick(:baz, :bar) #=> {:baz => 'foo', :bar => 'hello world' }
~~~


----------------------------------------
Feature #13563: Implement Hash#choice method.
https://bugs.ruby-lang.org/issues/13563#change-65088

* Author: babanba-n (matzbara masanao)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
----------------------------------------
Hi,

I propose Hash#choice method.

It pick up key and value pairs in Hash like a below code.

~~~
{ :a => 1, 2 => "2", "c" => true }.choice(:a, 2) # => { :a => 1, 2 => "2" }
{ :a => 1, 2 => "2", "c" => true }.choice("c", 10000) # => { "c" => true, 10000 => nil }
~~~

This method is useful when Hash have many keys, but programer need few key's.

For instance, it pick up personal data in ActiveRecord model's data, and migrate to new device.

~~~
feature_phone_user = User.find(params[:src_user_id])
profile = feature_phone_user.attributes.choice(*%i[nickname email sex birthday prefecture])
smart_phone_user   = User.new
smart_phone_user.attributes = profile
~~~
In other case, it pick up latest log from http request parameter.

~~~
condition = params.to_h.choice("user_id", "service_id")
latest_payment_log = PaymentLog.find_by(condition).last
~~~

If this method exist, I guess that many cases change to comfortable just a little.

Please consider about it.

And I write it.
https://github.com/baban/ruby/commit/4014ebe2ae261881669bef8369eb08aaecef2034




-- 
https://bugs.ruby-lang.org/