Issue #13368 has been updated by naruse (Yui NARUSE).


watson1978 (Shizuo Fujita) wrote:
> When I filed this ticket, I tried to run benchmark on macOS + clang only.
> Then, I tried to do on 2 environments in additional.
> 
> I found what my patch is effective with clang envrionment only (such as macOS or FreeBSD which use clang as default compiler).

Hmm, the result shows clang is not efficient as gcc yet this time.
And improvement should be done by clang, not us.
Or should be done by something cleaner patch.

----------------------------------------
Bug #13368: Improve performance of Array#sum with float elements
https://bugs.ruby-lang.org/issues/13368#change-64227

* Author: watson1978 (Shizuo Fujita)
* Status: Open
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 
* Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN
----------------------------------------
The declaration of local variable in loop, it will initialize local variable for each run of the loop with clang generated code.
So, it shouldn't declare the local variable in heavy loop.

Array#sum with float elements will be faster around 30%.

### Before
~~~
       user     system      total        real
   3.320000   0.010000   3.330000 (  3.336088)
~~~

### After
~~~
       user     system      total        real
   2.590000   0.010000   2.600000 (  2.602399)
~~~

### Test code
~~~
require 'benchmark'

Benchmark.bmbm do |x|
  ary = []
  10000.times { ary << Random.rand }

  x.report do
    50000.times do
      ary.sum
    end
  end

end
~~~

### Patch
https://github.com/ruby/ruby/pull/1555



-- 
https://bugs.ruby-lang.org/