[ruby-dev:45247] [ruby-trunk - Feature #1905][Rejected] How about IPAddr#<=> to take care of mask

< :蟆及⺀寞 ^ :⺀寞賜伉旦玄 > :慼及⺀寞 P :蟆及筏儀﹋旦伊永玉啖⑹﹌ N :慼及筏儀﹋旦伊永玉啖⑹﹌ |<:蟆及旦伊永玉 >|:慼及旦伊永玉 ^ :忒儀燮 _:憤坌尺及忒儀 >:⑺元忒儀燮毛儅勾筏儀﹋蟆﹌ <:⑺元忒儀燮毛儅勾筏儀﹋詨﹌ ---:坌喃仄化旦伊永玉刓憎﹜瘋刓憎 | :坌喃仄化﹋衝﹌旦伊永玉刓憎﹜瘋刓憎 ~ :旦伊永玉及白伊□丞壅蛔 .:奶件犯永弁旦 ..:奶件犯永弁旦及奶件犯永弁旦

Issue #1905 has been updated by Yusuke Endoh. Status changed from Assigned to Rejected ??瑟???????脣???????踴???????芥????柴?折???????整?????[ruby-core:42391] ????????扼?? 甇西??????????柴?～?潦?怒??????????賬?～?艾????艾?????????怒??????扼????准?? [ruby-dev:39381] [ruby-dev:39391] 甇西??????????格??獢??????? API ([ruby-dev:39391]) ??柴???????????雿???�?艾???????? ??????????????扼?????????????具????芥???????具?????敺???∠?嗆????冽?????????整????? ???????????瑟???????????????????乓?艾????芥????柴?扼??銝???艾?具??????????艾??????????整????? ??????????????扼???????? reopen ??芥????啜????晞?????雿??????芥???????艾????????????? FYI: znz ????????典??????????? (??????????????嫘?胯?? IP ???瘨????????????券?Ｗ??) ??胯?? https://bugs.ruby-lang.org/issues/1275 ??扼??????????�?艾?整???????? ??????????????艾????整?�?艾?整??????????????瘞??????????鈭箝?? reopen ?????艾????????????? -- Yusuke Endoh <mame / tsg.ne.jp> ---------------------------------------- Feature #1905: How about IPAddr#<=> to take care of mask_addr? https://bugs.ruby-lang.org/issues/1905 Author: Nobuhiro IMAI Status: Rejected Priority: Low Assignee: Akinori MUSHA Category: lib Target version: 2.0.0 =begin ?????整????扼????? #1877 ??胯??????????具?????????????整???????? IPAddr ??柴?扎?喋?嫘?踴?喋?嫘?????????瑯?乓?柴?准?潦?怠?箸?乓??????????怒?芥?�????柴?扼??蝪∪????? Access Control List ?????詻????艾?踴????柴?扼???????? >> RUBY_DESCRIPTION => "ruby 1.9.2dev (2009-08-07 trunk 24440) [i686-linux]" >> acl = { ?> IPAddr.new("192.168.2.0/29") => :admin, ?> IPAddr.new("192.168.2.0/24") => :user, ?> } => {#<IPAddr: IPv4:192.168.2.0/255.255.255.248>=>:admin, #<IPAddr: IPv4:192.168.2.0/255.255.255.0>=>:user} >> acl.select{|r, | r === "192.168.2.56"}.max.last => :user >> acl.select{|r, | r === "192.168.2.1"}.max.last => :user ??具????～????�?冽??敹萸?芣???????扼?????<=> ??扼??@addr ???????????游????? @mask_addr ??桀之 ????????嫘?? IPAddr ??具????血之????????具???????具????????????????嫘?胯?桅?瑯????嫘???﹝??具???????? ????????芥?扎?～?潦?詻?扼???????????瘞????????????柴?扼??????????押????扼???????????嚗? ??整??????????????(??具?????????????????嚗?) IPAddr#== ??臭??閬???芣?????????????柴?扼????????雿? ???閬???賬?具????艾????扼???????????嚗? IPAddr.new("192.168.2.0/24") == IPAddr.new("192.168.2.0/32") ??? true ?????? false ??怠?????????具?????隞?瑽?憭???氬?芥?柴?扼??????????押????扼???????????嚗? -- Nobuhiro IMAI <nov / yo.rim.or.jp> Key fingerprint = F39E D552 545D 7C64 D690 F644 5A15 746C BD8E 7106 Index: lib/ipaddr.rb =================================================================== --- lib/ipaddr.rb (revision 24440) +++ lib/ipaddr.rb (working copy) @@ -133,16 +133,10 @@ class IPAddr # Returns a new ipaddr built by bitwise negation. def ~ return self.clone.set(addr_mask(~@addr)) end - # Returns true if two ipaddrs are equal. - def ==(other) - other = coerce_other(other) - return @family == other.family && @addr == other.to_i - end - # Returns a new ipaddr built by masking IP address with the given # prefixlen/netmask. (e.g. 8, 64, "255.255.255.0", etc.) def mask(prefixlen) return self.clone.mask!(prefixlen) end @@ -325,11 +319,11 @@ class IPAddr def <=>(other) other = coerce_other(other) return nil if other.family != @family - return @addr <=> other.to_i + return [@addr, @mask_addr] <=> [other.to_i, other.mask_addr] end include Comparable # Checks equality used by Hash. def eql?(other) @@ -372,10 +366,12 @@ class IPAddr af, _to_string(@addr), _to_string(@mask_addr)) end protected + attr_reader :mask_addr + def set(addr, *family) case family[0] ? family[0] : @family when Socket::AF_INET if addr < 0 || addr > IN4MASK raise ArgumentError, "invalid address" @@ -789,15 +785,24 @@ class TC_Operator < Test::Unit::TestCase a = ~@in6_addr_any assert_equal(IN6MASK128, a.to_s) assert_equal("::", @in6_addr_any.to_s) end - def test_equal - assert_equal(true, @a == IPAddr.new("3ffe:505:2::")) + def test_compare + assert_equal(true, @a == IPAddr.new("3ffe:505:2::/48")) + assert_equal(false, @a == IPAddr.new("3ffe:505:2::")) assert_equal(false, @a == IPAddr.new("3ffe:505:3::")) assert_equal(true, @a != IPAddr.new("3ffe:505:3::")) - assert_equal(false, @a != IPAddr.new("3ffe:505:2::")) + assert_equal(false, @a != IPAddr.new("3ffe:505:2::/48")) + x = IPAddr.new("3ffe:505:3::/48") + y = IPAddr.new("3ffe:505:2::/64") + assert_equal(true, @a < x) + assert_equal(true, @a < y) + assert_equal(false, x < y) + min, max = [y, x, @a].minmax + assert_equal(@a, min) + assert_equal(x, max) end def test_mask a = @a.mask(32) assert_equal("3ffe:505::", a.to_s) =end -- http://bugs.ruby-lang.org/