Issue #16428 has been updated by kyanagi (Kouhei Yanagita).


In my cases, I (server side) only had to check duplication because a client=
 also have validations.
Legal users can't send a request with duplicates, so detailed error message=
 was not required.
(If needed, I could investigate logged request.)

`uniq!`'s return value is also usable, but I think `uniq?` is more fitting.
(I'd like to check duplication, not to get uniq array.)

----------------------------------------
Feature #16428: Add Array#uniq?, Enumerable#uniq?
https://bugs.ruby-lang.org/issues/16428#change-85026

* Author: kyanagi (Kouhei Yanagita)
* Status: Feedback
* Priority: Normal
----------------------------------------
I propose Array#uniq?.

I often need to check if an array have duplicate elements.

This method returns true if no duplicates are found in self, otherwise retu=
rns false.
If a block is given, it will use the return value of the block for comparis=
on.

This is equivalent to `array.uniq.size =3D=3D array.size`, but faster.

```
% ~/tmp/r/bin/ruby -rbenchmark/ips -e 'a =3D Array.new(100) { rand(1000) };=
 Benchmark.ips { |x| x.report("uniq") { a.uniq.size =3D=3D a.size }; x.repo=
rt("uniq?") { a.uniq? } }'
Warming up --------------------------------------
                uniq    25.765k i/100ms
               uniq?    76.544k i/100ms
Calculating -------------------------------------
                uniq    278.144k (=B1 4.1%) i/s -      1.391M in   5.010858s
               uniq?    981.868k (=B1 5.1%) i/s -      4.975M in   5.081611s
```

I think the name `uniq?` is natural because Array already has `uniq`.

patch: https://github.com/ruby/ruby/pull/2762



-- =

https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=3Dunsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>