Issue #16652 has been updated by shevegen (Robert A. Heiler).


I glanced at rbinstall.rb briefly; for those interested, the link should be here:

https://github.com/ruby/ruby/blob/master/tool/rbinstall.rb

That seems quite old code, lots of global variables in it as well. Props to
everyone able to improve on it. My best bet is that it was written a long
time ago. :-)

(I wondered if we could actually put all the .rb files that remain as part
of the ruby tarball into its own gem, but I am not sure if the effort may
be worth it. So props to you and everyone else who improves on old code!)

----------------------------------------
Feature #16652: Use RubyGems facilities to install Gems during Ruby installation
https://bugs.ruby-lang.org/issues/16652#change-84371

* Author: vo.x (Vit Ondruch)
* Status: Open
* Priority: Normal
----------------------------------------
Currently, `tools/rbinstall` uses quite some custom code to install gems instead of using functionality available in RubyGems. I don't think this is good, because the code is non transparent ATM and it is duplicating functionality, which is already available and tested in RubyGems. Also, it intoduces its own concepts such as `$script_mode` vs `$prog_mode`. So I opened two PRs, gradually implementing this.

The first PR [1] uses `Gem::Package` like object and duck typing instead of monkey patching.

1. This is similar to what RubyGems do and it is less magic [2].
2. It avoids deprecated code paths in RubyGems [3].

The second PR [4] builds on the top of the first one and uses `UnpackedInstaller` to install default gems (it would be probably nice to get `UnpackedInstaller` into RubyGems, but I am not sure how it could be invoked). As a bonus, it removes the pregenerated binstubs. These are now generated by `Gem::Installer` instead.



[1]: https://github.com/ruby/ruby/pull/2515
[2]: https://github.com/rubygems/rubygems/blob/92892bbc3adba86a90756c385433835f6761b8da/lib/rubygems/installer.rb#L151
[3]: https://github.com/rubygems/rubygems/blob/92892bbc3adba86a90756c385433835f6761b8da/lib/rubygems/installer.rb#L187
[4]: https://github.com/ruby/ruby/pull/2545



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>