Issue #14194 has been updated by MSP-Greg (Greg L). @jeremyevans0 Sorry for the tardy response, I had hoped to run a CI build with the flag set, but busy with other things... I was unaware that the decision had been made re Ruby 3. If you have any links to discussions, etc, I'd be interested. I have seen repos (Nokogiri comes to mind) testing with the flag set, so whatever parts of Ruby they're using are working. In a perfect world, and given that I mostly recall seeing postive comments about using frozen strings, I think Ruby should pass CI with it. I'll run a build with it and see how many tests/specs fail. This isn't a perfect world... Thanks, Greg ---------------------------------------- Bug #14194: --enable-frozen-string-literal ruby runner.rb cgi https://bugs.ruby-lang.org/issues/14194#change-78781 * Author: MSP-Greg (Greg L) * Status: Feedback * Priority: Normal * Assignee: * Target version: * ruby -v: ruby 2.5.0dev (2017-12-17 trunk 61304) [x64-mingw32] * Backport: 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- Assuming `--enable-frozen-string-literal`, `ruby runner.rb cgi` Running without patch: ``` 1) Failure: CGIMultipartTest#test_cgi_multipart_without_tempfile [E:/GitHub/ruby/test/cgi/test_cgi_multipart.rb:353]: 1. [2/2] Assertion for "stderr" | <[]> expected but was | <["-:20:in `gsub!': can't modify frozen String, created at -:5 (FrozenError)", | "\tfrom -:20:in `<main>'"]>. Finished tests in 3.042000s, 143.3268 tests/s, 333.3333 assertions/s. 436 tests, 1014 assertions, 1 failures, 0 errors, 0 skips ``` With patch: ``` Finished tests in 2.620800s, 166.3614 tests/s, 386.9048 assertions/s. 436 tests, 1014 assertions, 0 failures, 0 errors, 0 skips ruby -v: ruby 2.5.0dev (2017-12-17 trunk 61304) [x64-mingw32] ``` ---Files-------------------------------- frozen_cgi.patch (740 Bytes) -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>