Issue #15522 has been updated by vo.x (Vit Ondruch).


sharkcz (Dan Hork) wrote:
> I guess -nodefaultlibs should be omitted and/or -static-libgcc added. Skipping libgcc seems dangerous in general on any arch.

I removed `-nodefaultlibs` and it changed nothing. But reading GCC options [1] manual, the `-nostdlib` description, it says:

> In other words, when you specify -nostdlib or -nodefaultlibs you should usually specify -lgcc as well.

and indeed after adding `-lgcc`, the build passed. Also, the `-lgcc` is already used in some cases [2], maybe it should be used in all cases ...

[1]: https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html
[2]: https://github.com/ruby/ruby/blame/trunk/mjit_worker.c#L277

----------------------------------------
Bug #15522: TestJIT#test_compile_insn_local fails on aarch64 RHEL7
https://bugs.ruby-lang.org/issues/15522#change-76249

* Author: vo.x (Vit Ondruch)
* Status: Assigned
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* Target version: 
* ruby -v: ruby 2.6.0p0 (2018-12-25 revision 66547) [aarch64-linux]
* Backport: 2.4: UNKNOWN, 2.5: UNKNOWN, 2.6: UNKNOWN
----------------------------------------
Trying to build Ruby 2.6 on RHEL7, I observe the following test failure on RHEL7, but just on aarch64. The other platforms pass just fine:

~~~
  1) Failure:
TestJIT#test_compile_insn_local [/builddir/build/BUILD/ruby-2.6.0/test/ruby/test_jit.rb:64]:
Expected 3 times of JIT success, but succeeded 2 times.
script:
```
def foo
  a = 0
  [1, 2].each do |i|
    a += i
    [3, 4].each do |j|
      a *= j
    end
  end
  a
end
print foo
```
stderr:
```
JIT success (276.6ms): foo@-e:2 -> /tmp/_ruby_mjit_p20163u0.c
JIT success (347.3ms): block in foo@-e:4 -> /tmp/_ruby_mjit_p20163u1.c
MJIT warning: failure in loading code from '/tmp/_ruby_mjit_p20163u2.so': /tmp/_ruby_mjit_p20163u2.so: undefined symbol: __multi3
Successful MJIT finish
```
.
<3> expected but was
<2>.
~~~

I suspect this must be some combination of architecture/compiler (gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16)), because I don't observe similar issues on Fedora.



---Files--------------------------------
_ruby_mjit_p207u2.c (3.48 KB)
rb_mjit_min_header-2.6.0.h (781 KB)
mjit_multi3.tgz (993 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>