Issue #15318 has been updated by shugo (Shugo Maeda).

Status changed from Feedback to Rejected

normalperson (Eric Wong) wrote:
>  "Socket.tcp" been part of the public Ruby API for around 10 years
>  already.  socksify should be supporting it in addition to TCPSocket;
>  because there is code which uses Socket directly.

Agreed.

@sock is a private API and Socket is recommended over TCPSocket, so I wouldn't like to
revert the change.


----------------------------------------
Bug #15318: net/imap socket backward compatibility broken in ruby 2.5+
https://bugs.ruby-lang.org/issues/15318#change-74969

* Author: karis10 (bug reporter)
* Status: Rejected
* Priority: Normal
* Assignee: shugo (Shugo Maeda)
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
Hi,
I use net/pop and net/imap libraries and sometimes I need my pop/imap connections to be socksified or proxified (through TCPSocket initialize method modifications: https://github.com/Shopify/socksify-ruby). Upgrading to ruby 2.5.3 from 2.4.4 I've found that TCPSocket interface was changed in favor of raw sockets by this patch: https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/58549/diff/lib/net/imap.rb the reason was this issue: https://bugs.ruby-lang.org/issues/13379

And after migrating from 2.4.4 to 2.5.3 and a bit of debugging I've found that standard library behavior was internally _silently_ broken. In 2.5.3 net/pop library still can be normally proxified, but not net/imap.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>