Issue #15239 has been updated by suke (Masaki Suketa).


Thank you for your help. I prefer to use MSXML.Document for WIN32OLE_EVENT specs. 
Because I think other (light and more standard) COM objects (like Scripting.Dictionary) have features for other specs.
I applied the win32ole_event part of your patch to ruby-trunk.
Thank you again.

@k0kubun

> the assumption "this file is required on Windows only" seems not correct. I reverted that in r65402. Could you check it?

Sorry, I missed it and misunderstood. I retried requiring the file only when platform is Windows in r65416.

----------------------------------------
Misc #15239: [patch] test-spec win32ole
https://bugs.ruby-lang.org/issues/15239#change-74635

* Author: MSP-Greg (Greg L)
* Status: Open
* Priority: Normal
* Assignee: suke (Masaki Suketa)
----------------------------------------
Some of the current Win32OLE spec tests use the InternetExplorer control.  This control is not available on Azure pipelines. Attached patch changes to use the MSXML control, adds a guard for it, and also does some refactoring to lower requires when not run under Windows, etc.  Also, since the MSXML object is quite a bit 'smaller' than InternetExplorer, tests run faster.

Passed in my fork at https://ci.appveyor.com/project/MSP-Greg/ruby/builds/19663145

Note also that since there have been recent commits stabilizing the spec suite, the above build job changed the mswin spec tests to run parallel, and they passed.  The change from serial to parallel is not included in the patches.  It is a separate commit in the branch on my fork.

GitHub patch is at:
https://github.com/MSP-Greg/ruby/commit/d1daf9a66f491abfac5e84a50f152505baa1ccac.patch


---Files--------------------------------
spec_win32ole.patch (25.8 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>