Issue #14867 has been updated by MSP-Greg (Greg L).


@normalperson

I'm not sure what you look at on the web (GitHub, Appveyor), so briefly:

1. The mswin builds do not test MJIT, but mingw (ruby-loco) does.  Note that mingw tests 3 time a day, so I may not know what revision caused what.  The mingw test history is at https://ci.appveyor.com/project/MSP-Greg/ruby-loco/history.

2. When you first added commits (r63758), mingw wouldn't build, then once that was fixed, tests crashed.  As of r63794, it built, tests completed, but all JIT tests failed (they previously passed).  At that point, I removed the JIT results from the pass/fail logic.

3. The mswin build was functioning up until r63816.  The changes in r63820 (get rid of a compiler warning of VC) interacted with your commits to cause the mswin build to lock up.  If that interaction can be fixed, mswin may pass.

4. If I'm not AFK, I can certainly start a new build job to test a particular commit.  I can also easily add a patch to the build system.  Greg.mpls / gmail.com

I don't know if this info helps, but since you and everyone else here have always been helpful with windows issues, I certainly don't want Windows testing to jam up trunk improvements...  Thanks, Greg

----------------------------------------
Bug #14867: Process.wait can wait for MJIT compiler process
https://bugs.ruby-lang.org/issues/14867#change-72811

* Author: k0kubun (Takashi Kokubun)
* Status: Assigned
* Priority: Normal
* Assignee: normalperson (Eric Wong)
* Target version: 
* ruby -v: 
* Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN
----------------------------------------
If Ruby tries to wait for any child process, MJIT's gcc/clang process could be caught by the method call. It's not convenient for both Ruby's user and MJIT worker thread, so Process.wait and its families should somehow avoid waiting for it.

---Files--------------------------------
0001-hijack-SIGCHLD-handler-for-internal-use.patch (13.8 KB)
JIT-test-all.log (39.9 KB)
mjit_test-all_63796.log (40.4 KB)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>