On 02/19/2018 07:40 PM, takashikkbn / gmail.com wrote:
> Issue #12589 has been updated by k0kubun (Takashi Kokubun).
>
>
> Great work on rtl_gen, Vladimir! Keeping both stack insns and RTL insns would be good for safe migration.
Thank you, Takashi.
>> There were a lot of changes since then which will affect the code I am
> working on. The biggest one is Takashi Kokubun's work on MJIT for
> YARV. Another one is trace insns removal by Koichi Sasada.
>
> I hope your work on merging trunk to stack-rtl-mjit would be easy, which was the aim of Feature #14235. mjit_compile takes rb_iseq_constant_body and you should be able to read rtl_encoded from it. Merging it would make your work much portable, which is already running on many RubyCIs.
>
> After merging it, which includes some fixes for JIT in test cases, could you try running "make test-all RUN_OPTS='--jit-wait --jit-min-calls=1'", and also "make test-all RUN_OPTS='--jit-wait --jit-min-calls=5'" if you're using some cache of method calls? The testing strategy was used for merging Feature #14235, and it can make sure that JIT-ed code and RTL insns translated from stack insns work for many cases.
> You're calling abort() for "Not implemented" insns like run_once, but I think it should just skip compiling the ISeq and work, like current trunk. At least it would be needed to pass the test.
>
>
Thank you for the tips. I am planing to start on merging trunk into 
stack-rtl-mjit branch in a week or two.


Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>