Issue #14470 has been updated by tenderlovemaking (Aaron Patterson).


normalperson (Eric Wong) wrote:
> tenderlove / ruby-lang.org wrote:
>  > nobu (Nobuyoshi Nakada) wrote:
>  > > The feature page says "Include your trailers at the end of
>  > > your commit message", does it work even if "git-svn-id:"
>  > > line is appended by `git svn dcommit`?
>  > 
>  > It will work, but we have to ensure there is no newline
>  > between the git-svn-id trailer and the Co-authored-by trailer.
>  > I just did a test with a test SVN repository, and it looks
>  > like git-svn will insert a newline even if there are trailers
>  > at the end of the commit message.  Perhaps we could fix
>  > "git-svn", but it doesn't look like we can add arbitrary git
>  > trailers today.
>  
>  I wouldn't accept such a change to git-svn (explanation below).
>  Better to make trailer interpretation tolerate empty lines;
>  as trailers are a loose format, anyways (or filter out
>  git-svn-id: lines before interpreting trailers).
>  
>  
>  Since the earliest incarnations of git-svn in 2006, I've strived
>  to maintain deterministic behavior across git versions as long
>  as the same options (usually defaults) are used; so SHA-1
>  identifiers for commits could end up being identical (and thus
>  shareable) between contributors who previously had no contact.

Thanks for the background!  Maybe we can get this fixed in git then.  I'll see what I can find out!

----------------------------------------
Misc #14470: Use Commit together with co-authors Github feature in svn commits
https://bugs.ruby-lang.org/issues/14470#change-70343

* Author: ana06 (Ana Maria Martinez Gomez)
* Status: Open
* Priority: Normal
* Assignee: 
----------------------------------------
As currently Ruby is using SVN, for "merging" a PR, the PR is closed and the changes added in a SVN commit. In this commit the author is someone from the Ruby core and not the person who wrote the code. The person who wrote the code is mentioned in the commit message, but that doesn't give any visibility to the author of the code. I think giving proper attribution to the contributors of the projects is important to value them.

It seems that any solution was found to solve this problem, but I think that it could be now easily solved with the new [_Commit together with co-authors_ Github feature](https://github.com/blog/2496-commit-together-with-co-authors).

If in the commit message, instead of 

`Submitted by: @Ana06 <anamma06 / gmail.com>`

you write

`Co-authored-by: Ana Mara Martnez Gmez <anamma06 / gmail.com>`

Github will show the contribution as well.

What do you think? Would you be up to use it? I think it would be a really easy way to give contributors more visibility.  


There have been already some discussions in https://github.com/ruby/ruby/pull/1752



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>