Issue #14257 has been updated by nobu (Nobuyoshi Nakada).

Backport changed from 2.3: DONTNEED, 2.4: DONTNEED, 2.5: DONE to 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED

Sorry, r61636 is needed too.
Huge RS with `chomp` option could cause a SEGV.

----------------------------------------
Bug #14257: the chomp option removes newlines in additon to the provided separator for String#each_line and String#lines
https://bugs.ruby-lang.org/issues/14257#change-69391

* Author: AaronLasseigne (Aaron Lasseigne)
* Status: Closed
* Priority: Normal
* Assignee: 
* Target version: 
* ruby -v: 2.5.0
* Backport: 2.3: DONTNEED, 2.4: DONTNEED, 2.5: REQUIRED
----------------------------------------
I'm not entirely sure this is a bug but I had a hard time finding anything that indicated that the change was on purpose.

The `chomp` option would remove the provided separator from each line. Now it does that and it also removes newlines.

2.4

~~~ ruby
> "a b c d\n".lines(' ', chomp: true)
=> ["a", "b", "c", "d\n"]
~~~

2.5

~~~ ruby
> "a b c d\n".lines(' ', chomp: true)
=> ["a", "b", "c", "d"]
~~~





-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>