Issue #9990 has been updated by naruse (Yui NARUSE).

Status changed from Assigned to Closed

[Bug #10402] allows [ and ].
Therefore it's not problem in practical.

----------------------------------------
Bug #9990: URI.parse and URI.encode use different RFCs
https://bugs.ruby-lang.org/issues/9990#change-68112

* Author: lengarvey (Leonard Garvey)
* Status: Closed
* Priority: Normal
* Assignee: naruse (Yui NARUSE)
* Target version: 
* ruby -v: 2.2.0dev
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
The latest code for URI.parse uses RFC3986 but URI.encode/URI.escape still uses the old URI::RFC2396_Parser implementation of encode. This causes problems when the specs diverge.

In RFC3986 square brackets "[" and "]" are reserved and need to be percent encoded in the query string, although they didn't in RFC2396. This means the the following url cannot be parsed by the new parser, and isn't encoded correctly by the old encoder: https://bugs.ruby-lang.org/projects/ruby-trunk/issues?set_filter=1&f[]=status_id&op[status_id]=o

Here's a quick ruby script which demonstrates the issue on 2.2.0dev:

~~~
url = "https://bugs.ruby-lang.org/projects/ruby-trunk/issues?set_filter=1&f[]=status_id&op[status_id]=o"
puts URI.encode(url)
URI.parse(URI.encode(url))
~~~

The output of running this script can be seen at: https://gist.github.com/lengarvey/c1d17913f9ea95fd999c

I believe a new encoder needs to be written up according to the RFC3986 spec and this should be used as the default in URI.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>