Issue #13943 has been updated by k0kubun (Takashi Kokubun).

Assignee changed from k0kubun (Takashi Kokubun) to znz (Kazuhiro NISHIYAMA)

Thank you for showing benchmark result.
While the impact is not so large with that benchmark, this would be expected usage of #unpack1 and it's good for maintainability too. So I think "not being slower in benchmark" is enough for adding this change.
I'm +1 for committing this.

----------------------------------------
Feature #13943: Use unpack1 instead of unpack(template)[0] in erb.rb
https://bugs.ruby-lang.org/issues/13943#change-66973

* Author: znz (Kazuhiro NISHIYAMA)
* Status: Assigned
* Priority: Normal
* Assignee: znz (Kazuhiro NISHIYAMA)
* Target version: 
----------------------------------------
I think `unpack1(template)` is faster than `unpack(template)[0]`.

Attached patch for `lib/erb.rb`.

---Files--------------------------------
erb-unpack1.diff (355 Bytes)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>