Issue #13943 has been updated by wyhaines (Kirk Haines).


It should implicitly be faster, as it avoids the array creation, insertion, and dereferencing that occurs with:

m.unpack("C")[0]

However, a benchmark to quantify the difference would be nice to have.

----------------------------------------
Feature #13943: Use unpack1 instead of unpack(template)[0] in erb.rb
https://bugs.ruby-lang.org/issues/13943#change-66946

* Author: znz (Kazuhiro NISHIYAMA)
* Status: Assigned
* Priority: Normal
* Assignee: k0kubun (Takashi Kokubun)
* Target version: 
----------------------------------------
I think `unpack1(template)` is faster than `unpack(template)[0]`.

Attached patch for `lib/erb.rb`.

---Files--------------------------------
erb-unpack1.diff (355 Bytes)


-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>