Hi, In <Pine.GSO.4.64.0607121836100.17386 / brains.eng.cse.dmu.ac.uk> "rss patch -- mostly doc, plus English adjustments." on Thu, 13 Jul 2006 02:50:53 +0900, Hugh Sasse <hgs / dmu.ac.uk> wrote: > I've tried to improve the error messages, and add comments to the > code where I can. I'm not 100% certain how plurals are used in the > dublincore code: in particular if they need to be distinct words > from the single form (an assumption not always true in English (1 > sheep, many sheep, similarly for deer...)). Obviously more needs > doing to RSS in terms of rdoc docs but if this gets under the wire > for 1.8.5 final it would be a start. Very thanks, Hugh! I applied your patch but... > --- ./lib/rss/dublincore.rb.orig 2006-06-20 12:50:52.000000000 +0100 > +++ ./lib/rss/dublincore.rb 2006-07-12 18:34:58.990946000 +0100 > @@ -61,7 +61,10 @@ > "language" => nil, > "relation" => nil, > "coverage" => nil, > - "rights" => "rightses" # FIXME > + "rights" => "rights" # <FIXME> this refers to a set of management rights > + # If you add more rights it remains plural. > + # I can't see anywhere that these names must be > + # distinct. "deer" => "deer" etc. </FIXME> > } I rejected the above changes. Because this changes breaks backward compatibility. Regards, -- kou