> > @@ -408,7 +408,7 @@ > > - while (c = *str++) { > > + while ((c = *str++)) { > > These "cleanup"s may not work for all compilers. If you really > want, > > > + while ((c = *str++) != 0) { Either (()) or ((a) != 0) are pretty superficial and only matter in making the build process quieter. I defer to matz's code preference and will leave them alone unless he has a suggested way of quieting that warning. > > -static char sccsid[] = "@(#) st.c 5.1 89/12/14 Crucible"; > > +/* static char sccsid[] = "@(#) st.c 5.1 89/12/14 Crucible"; */ > > FYI, some compilers (ex. GCC) are satisfied with const. I'll use const then: thank you. -- Sean Chittenden