[ruby-core:81969] [Ruby trunk Bug#13726] PATCH: Windows builds

< :前の番号 ^ :番号順リスト > :次の番号 P :前の記事（スレッド移動） N :次の記事（スレッド移動） |<:前のスレッド >|:次のスレッド ^ :返事先 _:自分への返事 >:同じ返事先を持つ記事（前） <:同じ返事先を持つ記事（後） ---:分割してスレッド表示、再表示 | :分割して（縦）スレッド表示、再表示 ~ :スレッドのフレーム消去 .:インデックス ..:インデックスのインデックス

Issue #13726 has been updated by kubo (Takehiro Kubo). 01-time-subsec.patch changes declarations in include/ruby/win32.h. IMO, it could be in ruby 2.5.x but could not be backported to ruby 2.4.x because of ABI incompatibility. It also deletes meaningless TZ checking I pointed at #13702. ---------------------------------------- Bug #13726: PATCH: Windows builds - fractional second file times https://bugs.ruby-lang.org/issues/13726#change-65693 * Author: MSP-Greg (Greg L) * Status: Open * Priority: Normal * Assignee: * Target version: * ruby -v: trunk * Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN ---------------------------------------- At present, I believe Windows builds have integer seconds resolution on File times. Attached are three patches that seem to correct the issue. The numbered patches are best applied in order. The c source patches were created by kubo (Kubo Takehiro); I created the spec patch, along with some testing. All related tests (run parallel) pass on my system for MinGW builds and x64-mswin64_140 builds. I did some checks with Appveyor, and there may be issues with the logger tests, due to the fact that the tests are very time sensitive (I ran -j3 on a quad system, Appveyor runs -j2 on a dual core). I believe file time values are stored with 100 ns resolution, but times have 100 s resolution. This was the reason for some of the changes to the tests, as time appears to be truncated (floor), as opposed to round. I would appreciate if consideration could be given to adding this (or similar) code. Thank you. ---Files-------------------------------- 02-file-utime.patch (5.53 KB) spec-rubyspec-core-file-time.patch (2.99 KB) 01-time-subsec.patch (15.2 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe> <http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>