Issue #13156 has been updated by Yukihiro Matsumoto.

Status changed from Open to Feedback

I have several concerns:

* If `ruby/spec` tries to be a **common** executable specification of the language, it seems unnatural to have it in the repository of one particular implementation.

* Merging it would reduce synchronization cost. But I suspect your real intention is to make `ruby/spec` as a canonical test/spec suite, right? In that case, merging would not accomplish your real intention as some committers had shown their concerns about merging it, e.g. the difference between implementation test and executable spec, or difficulties of describing language behaviors using a relatively thick library (mspec) written in the language you are testing, etc.

In short, I am OK to merge it to the repository, as long as you are OK with above concerns.

Matz.


----------------------------------------
Feature #13156: In-tree copy of ruby/spec
https://bugs.ruby-lang.org/issues/13156#change-63094

* Author: Benoit Daloze
* Status: Feedback
* Priority: Normal
* Assignee: Yukihiro Matsumoto
* Target version: 
----------------------------------------
I would like to integrate an in-tree copy of ruby/spec under spec/rubyspec/
(at the same location ruby/spec is currently cloned to ease transition).
This way, implementation and tests can be changed in a single commit, just like with MRI tests.
I will keep synchronizing the changes to ruby/spec, so it can be used
directly and other people can contribute there.
I know this synchronization works because I have been doing it for over 2 years.
This process is also well documented:
https://github.com/ruby/spec/wiki/Merging-specs-from-JRuby-and-other-sources

My main motivation is the current status is suboptimal as
ruby/spec is a different repository and there are synchronization problems.
For example, if a change happens on MRI trunk and it needs to adapt
ruby/spec, it will pass either ruby/ruby CI or ruby/spec CI but never both.
I want to fix this and I want to encourage CRuby developers to write specs.

If you want more details, please look at my ruby-core post:
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/78633

Please state you opinion, I would like to integrate this soon.



-- 
https://bugs.ruby-lang.org/

Unsubscribe: <mailto:ruby-core-request / ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>