Hi. >Attached is a patch against Ruby 1.8.4 which cleans up the HTML output >of RDoc. Here's a list of the changes: > >* properly quote bare element attributes >* terminates dangling elements (e.g. <img>, <br>, <link>, etc) >* adds an --html-language command-line option and corresponding > 'html_lang' to specify HTML > language (e.g. the lang and xml:lang attributes) >* makes image filename suffix recognition case-insensitive >* converts "CVS" to the more HTML-friendly "<acronym title='Concurrent > Versioning System'>CVS</acronym>" >* adds missing type attributes to style elements >* allows UTF-8 as a valid charset option, and switches > HTML template to use %charset% and %html_lang% instead of hard- > coded 'utf-8' and 'en', respectively >* miscellaneous small changes (> => >, lower-case a few element > names for consistency, etc) > > > >-- >Paul Duncan <pabs / pablotron.org> OpenPGP Key ID: 0x82C29562 >http://www.pablotron.org/ http://www.paulduncan.org/ I have reviewed your patch, and have noticed two things. 1. In your patch, xml:lang is specified in HTML4.01. Is this allowed? in lib\rdoc\generators\template\html\old_html.rb <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html lang="%html_lang%" xml:lang="%html_lang%"> 2. If either charset or html_lang is not specified, rdoc ..\ruby_1_8\array.c --charset=SHIFT_JIS -o \temp I get <html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xml:lang="en-US"> <head> <title>RDoc Documentation</title> <meta http-equiv="Content-Type" content="text/html; charset=SHIFT_JIS" /> But this is strange. I think <html xmlns="http://www.w3.org/1999/xhtml"> <head> <title>RDoc Documentation</title> <meta http-equiv="Content-Type" content="text/html; charset=SHIFT_JIS" /> is more reasonable.