Issue #9129 has been updated by kallistec (Daniel DeLeo).


Hi Eric,
Earlier ruby versions handled proxy support differently (I'm not very familiar with either the old or new code), so my repro won't show that. The issue is that HTTP#proxy_uri is in the path for all HTTP requests, at least the way I'm using Net::HTTP. Here is a section of stack trace from my application:

/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/generic.rb:214:in `initialize'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/http.rb:84:in `initialize'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in `new'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in `parse'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:747:in `parse'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:994:in `URI'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:1027:in `proxy_uri'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:1014:in `proxy?'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:868:in `connect'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:862:in `do_start'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:851:in `start'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:1367:in `request'

If I understand correctly, the first argument to Net::HTTP.new should be an address that you can safely pass on to the socket layer code. For example, run this on Ruby 1.9.3:

ruby -rnet/http -e "Net::HTTP.new('::1', 80).get('/')" # works if you're running an HTTP server, Errno::ECONNREFUSED otherwise

Whereas this:

ruby -rnet/http -e "Net::HTTP.new('[::1]', 80).get('/')"

Gives you "getaddrinfo: nodename nor servname provided, or not known (SocketError)" because it's treating the whole thing with the brackets as the hostname/address.

It's true that in URIs you need to wrap an IPv6 literal in square brackets, which is why I believe this particular line of code is incorrect: https://github.com/ruby/ruby/blob/trunk/lib/net/http.rb#L1028

Thanks
----------------------------------------
Bug #9129: Regression in support for IPv6 literals in URIs with Net::HTTP
https://bugs.ruby-lang.org/issues/9129#change-43038

Author: kallistec (Daniel DeLeo)
Status: Assigned
Priority: Normal
Assignee: naruse (Yui NARUSE)
Category: lib
Target version: 
ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin12.4.0]
Backport: 1.9.3: DONTNEED, 2.0.0: UNKNOWN


The proxy code in Net::HTTP constructs a URI string by concatenating the address with the port. If the address is IPv6, this is incorrect, the address should be surrounded by square brackets. My code is failing in the Net::HTTP#proxy_uri method. The error can be reproduced by:

ruby -r'net/http' -e 'Net::HTTP.new("::1", 80).proxy_uri'
/Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/generic.rb:214:in `initialize': the scheme http does not accept registry part: ::1:80 (or bad hostname?) (URI::InvalidURIError)
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/http.rb:84:in `initialize'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in `new'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:214:in `parse'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:747:in `parse'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/uri/common.rb:994:in `URI'
	from /Users/ddeleo/.rbenv/versions/2.0.0-p247/lib/ruby/2.0.0/net/http.rb:1027:in `proxy_uri'
	from -e:1:in `<main>'


Though I've not tried to reproduce on current trunk, the implementation of Net::HTTP#proxy_uri is unchanged from 2.0.0p0 and current trunk.

My application's tests pass if I monkey patch that method as follows:

      def proxy_uri # :nodoc:
        ipv6_safe_addr = address.to_s.include?(":") ? "[#{address}]" : address
        @proxy_uri ||= URI("http://#{ipv6_safe_addr}:#{port}").find_proxy
      end



-- 
http://bugs.ruby-lang.org/