Issue #8034 has been updated by luislavena (Luis Lavena). h.shirosaki (Hiroshi Shirosaki) wrote: > Luis, thank you for your work. > `xfree(wpath);` would be needed before rb_raise(rb_eArgError, "can't find user %s"... > Indeed refactoring is better if possible. Hiroshi, I've pushed the refactored code as r39751 and corrected the style issue you mentioned. Thank you. I noticed getting the user home directory when detected "~" in either wpath or wdir can be refactored too. But that is for another ticket :) Thank you. ---------------------------------------- Bug #8034: File.expand_path('something', '~') do not include home path https://bugs.ruby-lang.org/issues/8034#change-37601 Author: rap-kasta (Pavel Manylov) Status: Closed Priority: Normal Assignee: luislavena (Luis Lavena) Category: platform/windows Target version: ruby -v: 1.9.3p362 =begin Next code works correctly only on ruby <= 1.9.3p362. Tested on Windows XP, Windows 2008 with ruby 1.9.3p194 (works properly), ruby 1.9.3p362 (bug), ruby 2.0.0p0 (bug). (({File.expand_path('something', '~') #=> "C:/path/to/current/dir/~/something"})) However, next code works as it should in all tested rubies: (({File.expand_path '~' # => "C:/Documents and Settings/Jack" Dir.home # => "C:/Documents and Settings/Jack"})) =end -- http://bugs.ruby-lang.org/