Issue #6236 has been updated by drbrain (Eric Hodel).

File webrick.signal_exception.patch added

Since process-management libraries use other signals than SIGINT to terminate processes, such as SIGTERM, I think WEBrick should rescue and exit on any signal, not just Interrupt, so SignalException is better.  See the attached patch.

Sending SIGINT to $$ raises an exception in the main thread (the test thread) not the WEBrick server thread which does not exercise the same code path.  The test should exercise that WEBrick shuts down correctly upon ^C, not that assert_raises catches signal exceptions on the main thread and that the ensure in TestWEBrick#start_server works.

Alex, at r35315 besides NoMemoryError and SignalException, only StandardError subclasses can be raised from the WEBrick accept loop as no user code is run in the accept loop.  If, for example, user code causes a SystemStackError, that error will only terminate the connection thread and will not propagate to the WEBrick server thread.
----------------------------------------
Feature #6236: WEBrick::HTTPServer swallows Exception
https://bugs.ruby-lang.org/issues/6236#change-25890

Author: regularfry (Alex Young)
Status: Closed
Priority: Normal
Assignee: nahi (Hiroshi Nakamura)
Category: lib
Target version: 2.0.0


At the moment when using WEBrick you've always got to remember to define a signal handler to be able to kill the server when you're done with it.  This is annoying and makes it more painful to use than it should be, because if you realise you've forgotten to define a trap("INT") handler after you've started the server, all you can do is kill -9 the process.  This also catches out people learning the library more than it should.  It shouldn't be the web server's job to take over process management, but that's what it ends up doing.

The reason this happens is because webrick/server.rb uses `rescue Exception` around its accept loop.  This is more broad than it should be.  The attached patch replaces this with a `rescue StandardError`, and causes other Exception subclasses to be logged and re-raised.  This makes WEBrick::HTTPServer somewhat more friendly to use at the command-line.

If you Ctrl-c out of a `server.start` loop with this patch applied, you can't restart the server because it leaves internal state lying around, but I think it's still an improvement over the current situation.


-- 
http://bugs.ruby-lang.org/