< :前の番号
^ :番号順リスト
> :次の番号
P :前の記事(スレッド移動)
N :次の記事
|<:前のスレッド
>|:次のスレッド
^ :返事先
_:自分への返事
>:同じ返事先を持つ記事(前)
<:同じ返事先を持つ記事(後)
---:分割してスレッド表示、再表示
| :分割して(縦)スレッド表示、再表示
~ :スレッドのフレーム消去
.:インデックス
..:インデックスのインデックス
Issue #6236 has been updated by drbrain (Eric Hodel).
Target version set to 2.0.0
I extended Alex's patch to include safe shutdown and to allow ^C to work from within accept_client.
Since each connection is handled in a separate thread, my concern about exception-tollerance was not founded.
----------------------------------------
Feature #6236: WEBrick::HTTPServer swallows Exception
https://bugs.ruby-lang.org/issues/6236#change-25837
Author: regularfry (Alex Young)
Status: Closed
Priority: Normal
Assignee: drbrain (Eric Hodel)
Category: lib
Target version: 2.0.0
At the moment when using WEBrick you've always got to remember to define a signal handler to be able to kill the server when you're done with it. This is annoying and makes it more painful to use than it should be, because if you realise you've forgotten to define a trap("INT") handler after you've started the server, all you can do is kill -9 the process. This also catches out people learning the library more than it should. It shouldn't be the web server's job to take over process management, but that's what it ends up doing.
The reason this happens is because webrick/server.rb uses `rescue Exception` around its accept loop. This is more broad than it should be. The attached patch replaces this with a `rescue StandardError`, and causes other Exception subclasses to be logged and re-raised. This makes WEBrick::HTTPServer somewhat more friendly to use at the command-line.
If you Ctrl-c out of a `server.start` loop with this patch applied, you can't restart the server because it leaves internal state lying around, but I think it's still an improvement over the current situation.
--
http://bugs.ruby-lang.org/