Issue #4970 has been updated by Thomas Sawyer.


Aaron Patterson looked at it, his only remarks were that I forgot to remove a spurious comment and that I changed the indention on `private`. Since, he said nothing about the implementation itself, I am assuming it looked okay to him.

I would remove the unnecessary comment myself, but I seem to have deleted the repo I was working on, and I am not sure there is a way to get it back such that I can update the same pull request. It would just be easier to merge then remove the comment, and if deemed necessary, rebase to a single commit.

----------------------------------------
Feature #4970: FileUtils refactored
https://bugs.ruby-lang.org/issues/4970

Author: Thomas Sawyer
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 2.0.0


I've been working with FileUtils a good bit, and concluded it could use some refactoring to make the code clearer and easier to work with. Here is the pull request:

  https://github.com/ruby/ruby/pull/30

Essentially, I have removed the method definition loops that occur at the end of the script and replaced them with a simple call (`define_command`) made for each command as it is defined. This allowed me to use `extend self` all the way through, rather than having to use `module_function` in FileUtils and `extend self` in the Verbose, NoWrite and DryRun "submodules".


-- 
http://bugs.ruby-lang.org/