Issue #5625 has been updated by Eric Hodel.


I've looked through two of your patches and if we're going to remove profanity then let's not simply replace words you don't like with another word that leaves an equally unhelpful comment or method name.

The first chunk of profanity.patch should be fixed not not mess up "p1"

The second chunk indicates the following line should be rewritten into something readable.

The third chunk indicates a proper comment is needed for this variable

The fifth chunk indicates the method should be fixed

The final chunks replace the completely non-descriptive method "util_fuck_with_fetcher" with the equally completely non-descriptive method "util_muck_with_fetcher".  The method name should be replaced with a properly descriptive method name.

If your goal is to "to ensure that parents or teachers would be less likely to choose to block children's access to Ruby source code" I don't see why you wish to also remove pejoratives. Certainly there are far more books in a school library packed with pejoratives than you've found in the ruby source code. Uncle Tom's Cabin comes to mind first, and I'm sure there are more instances of "fuck" in print in a library than you've found in ruby. While I've never heard of access to any source code being blocked anywhere due to either profanity or pejoratives, perhaps it occurs in countries with fewer freedoms.

The first chunk of pejorative.patch is a useful change.

The second chunk may as well omit "bad" since it is as useless an addition as "lame".

The third and fourth chunk should say something useful.  Neither "tarded" nor "ouch" are useful.

I don't presently see how the two patches you've provided improve ruby's source code beyond removing words you don't like. I would be more receptive if they improved ruby's source for everyone.
----------------------------------------
Bug #5625: Remove profanity and pejoratives
http://redmine.ruby-lang.org/issues/5625

Author: Andrew Grimm
Status: Third Party's Issue
Priority: Normal
Assignee: Eric Hodel
Category: 
Target version: 
ruby -v: F**king external libraries


There are currently 6 lines with the f-word, 4 lines with "wtf" that weren't just random combinations of letters, and one line with "bullshit". 

While I personally dislike such profanity, the main benefit from getting rid of it is that it'd mean people of all ages could read Ruby's source code.

There's also three lines where "lame" is used as a pejorative. Using a group of people as a pejorative should be avoided.


-- 
http://redmine.ruby-lang.org