SASADA Koichi <ko1 / atdot.net> wrote: > (2011/06/23 20:53), Mark Somerville wrote: > > On Sat, Jun 18, 2011 at 08:55:19AM +0900, Eric Wong wrote: > >> Eric Wong <normalperson / yhbt.net> wrote: > >>> I'm testing the following fix on my server: > >>> http://bogomips.org/ruby.git/commit/?h=sleepy-timer-thread&id=9154363119 > >> > >> One more patch below: > >> http://bogomips.org/ruby.git/commit/?h=sleepy-timer-thread&id=853275cb9ec > > > > Which patchset would it be most useful if I test first (I may only have > > time to test one). Koichi's or Eric's? I just switched my server to an updated version of the patch below. My previous sleepy-timer-thread branch has been running for nearly a week with no issues on bogomips.org. > http://www.atdot.net/sp/view/5d09nl/readonly > Here is a latest one (and I will commit it). FD_CLOEXEC needs to be set with F_SETFD, not F_SETFL. It also needs to be set on both descriptors, not just the writer: http://bogomips.org/ruby.git/commit/?h=sleepy2&id=c8d6093b029 5d09nl looks good otherwise and I'm running with my above change on bogomips.org. I will report back if I have any problems (or if you notice bogomips.org stops responding :) -- Eric Wong