--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 19, 2010 at 05:11:54PM +0900, Michael Malone wrote:
> Hi,
>=20
> I have been coding in Ruby for a couple of years professionally now, and I
> decided I would like to contribute.  I want to add the ability to require=
 a
> file that has no extension whatsoever (as a gentle introduction) and I wo=
uld
> start the conversation as to whether it was a good feature or not alongsi=
de
> the patch implementing it.  When I went to do said change, I thought the
> file in question could use a bunch of refactoring, but felt that might be=
 a
> little arrogant for my first submission.  So my question is, am I going to
> offend people if I start jumping in and changing code structure like ther=
e's
> no tomorrow?  Or should I learn to like the existing style?  Or am I going
> to annoy people more by writing this sort of question to the core mailing
> list?

Make the smallest possible patch to add the feature you want.  Submit a
separate patch for code refactoring.  From my experience, it is more
difficult to get a patch applied when multiple things are going on in
the patch.

HTH.

--=20
Aaron Patterson
http://tenderlovemaking.com/

--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iQEcBAEBAgAGBQJL9ANJAAoJEJUxcLy0/6/GdBAH/2SGwttbh+1Ykw0E5jV1LRsa
8KcUHw42POblnJsDihqbwgvf7BVqI/W0QlmoFOJIUCfUT+wzCqpBDCPfNY2ZFwtp
pOQsUbQO/L6em1Qb63d5WD9VZAEUjA+hIT2Dw04vx3GbFIz5PGsw+ijjyQFxXoLu
sfIuY6QiAKwtzTKbIi8rfa9PKmYN4SaQxjT3yeH5moyV1airhSTEpMrsZSpmjKVU
9QruPWnrQ6vdiMtxTDkL/QTHq64OJ7xvqq/IIw4RoIXaWzjNYzrGEfLPdC45Fd8A
cAHnzHV++WJ/AJdAIiclROMEzJTDIa3azxM+SqE+LV0meHJ4okODylAmbpZYKQk=
=yASL
-----END PGP SIGNATURE-----

--ew6BAiZeqk4r7MaW--

On Wed, May 19, 2010 at 05:11:54PM +0900, Michael Malone wrote:
> Hi,
>=20
> I have been coding in Ruby for a couple of years professionally now, and I
> decided I would like to contribute.  I want to add the ability to require=
 a
> file that has no extension whatsoever (as a gentle introduction) and I wo=
uld
> start the conversation as to whether it was a good feature or not alongsi=
de
> the patch implementing it.  When I went to do said change, I thought the
> file in question could use a bunch of refactoring, but felt that might be=
 a
> little arrogant for my first submission.  So my question is, am I going to
> offend people if I start jumping in and changing code structure like ther=
e's
> no tomorrow?  Or should I learn to like the existing style?  Or am I going
> to annoy people more by writing this sort of question to the core mailing
> list?

Make the smallest possible patch to add the feature you want.  Submit a
separate patch for code refactoring.  From my experience, it is more
difficult to get a patch applied when multiple things are going on in
the patch.

HTH.

--=20
Aaron Patterson
http://tenderlovemaking.com/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)

iQEcBAEBAgAGBQJL9ANJAAoJEJUxcLy0/6/GdBAH/2SGwttbh+1Ykw0E5jV1LRsa
8KcUHw42POblnJsDihqbwgvf7BVqI/W0QlmoFOJIUCfUT+wzCqpBDCPfNY2ZFwtp
pOQsUbQO/L6em1Qb63d5WD9VZAEUjA+hIT2Dw04vx3GbFIz5PGsw+ijjyQFxXoLu
sfIuY6QiAKwtzTKbIi8rfa9PKmYN4SaQxjT3yeH5moyV1airhSTEpMrsZSpmjKVU
9QruPWnrQ6vdiMtxTDkL/QTHq64OJ7xvqq/IIw4RoIXaWzjNYzrGEfLPdC45Fd8A
cAHnzHV++WJ/AJdAIiclROMEzJTDIa3azxM+SqE+LV0meHJ4okODylAmbpZYKQk=
=yASL
-----END PGP SIGNATURE-----