On Sep 22, 2009, at 20:19 , Nobuyoshi Nakada wrote:

>>> +static void
>>> +set_boolean(struct parser_params *parser, int *p, const char *val)
>> Is this really necessary? I'd rather stick to ruby values and remove
>> enable/yes/disable/no.
> What do you mean by `ruby values'?

ruby literals: true | false

>> Also, it is only being used once, so why bother abstracting it? Matz
>> is (rightfully) against using magic comments, so why enable them
>> further?
>
> Because it seemed more readable to me at that time.

yeah, but I think that is mitigated in part by only allowing true/false.