This discussion seems to have died out. Is this something which should/will be fixed. Should I open a bug ticket? On Thu, Aug 27, 2009 at 12:53 PM, Yusuke ENDOH <mame / tsg.ne.jp> wrote: > Hi, > > 2009/8/27 Rick DeNatale <rick.denatale / gmail.com>: >> On Wed, Aug 26, 2009 at 7:25 PM, Yukihiro Matsumoto<matz / ruby-lang.org> wrote: >>> Hi, >>> >>> In message "Re: [ruby-core:25143] Is this an intentional change in 1.9?" >>> ¨ÂÔèõ¬ ²· Áõ²°°¹ °²º³°ºµ± «°¹°°¬ Òéãë ÄåÎáôáìå ¼òéãë®äåîáôáìåÀçíáéì®ãïí÷òéôåó>>> >>> |This seems like a 1.9 bug. Is it? >>> >>> I vaguely remember ko1 explained me about the change due to a YARV >>> internal issue. ¨Âèáöå ôï ÷áéô ëïôï äåôåòíéîéô§ó âõïò îïô® >> >> I think it's a code generation issue, and also that it's important not >> to change the semantics of a.x ||= value > > > I agree. ¨Â åøðåãôåä ôèáô àá®ø üüöáìõå§ éó åñõáôï àá®ø üü ᮽáìõå§> but 1.9 cheated on me. > > > ¨Â Ïâêåãô®îå÷ > ¨Âåæ á®æïï» îéì» åî> ¨Âåæ á®æïィø©» ºâïïåî> > ¨Â¨á®æïï üüºæïï½¾ ºâïï > ¨Â¨á®æïï üü á®æïºæïºæïï > > > Here is a patch. ¨Âèåá®òåôõòîîéïò æáìóå¬ ôèòåíïòå éîóôòõãôéïîó > are executed than current implementation. ¨Â èáöå îïíåáóõòåä áãôõáì > impact of speed. > > > Index: compile.c > =================================================================== > --- compile.c (revision 24684) > +++ compile.c (working copy) > @@ -3842,22 +3842,26 @@ > ¨Âìãæé > ¨Âïð > ¨Âöá > - send a= # v > - jump lfin # v > + swap v r > + topn 1 v r v > + send a= # v ? > + jump lfin # v ? > > ¨Âãæéî > ¨Â÷á > + > + lfin: # o ? > ¨Âïð > > - lfin: # v > - > and > ¨Âõð > ¨Âîìåóìãæé> ¨Âïð > ¨Âöá > - send a= # v > - jump lfin # v > + swap v r > + topn 1 v r v > + send a= # v ? > + jump lfin # v ? > > others > ¨Âöá > @@ -3881,15 +3885,17 @@ > ¨Â > ¨ÂÄÄßÉÎÓΨòåô¬ îäßìéîå¨îïä婬 ðïð©> ¨ÂÏÍÐÉÌŨòåô¢ÎÏÄÅßÏÐßÁÓÇβ öáì¢îïäå¾îäßöáìõå©» > + ADD_INSN(ret, nd_line(node), swap); > + ADD_INSN1(ret, nd_line(node), topn, INT2FIX(1)); > ¨ÂÄÄßÓÅÎĨòåô¬ îäßìéîå¨îïä婬 ÉIJÓÙͨîïäå¾îäßîåøô¾îäßáé䩬 > INT2FIX(1)); > ¨ÂÄÄßÉÎÓĮ̂òåôîäßìéîå¨îïä婬 êõíðìæéî©» > > ¨ÂÄÄßÌÁÂĄ̊òåôìãæéî©> ¨ÂÄÄßÉÎÓΨòåô¬ îäßìéîå¨îïä婬 ó÷áð©» > - ADD_INSN(ret, nd_line(node), pop); > > ¨ÂÄÄßÌÁÂĄ̊òåôìæéî©» > + ADD_INSN(ret, nd_line(node), pop); > ¨Â > ¨Âìó> ¨ÂÏÍÐÉÌŨòåô¢ÎÏÄÅßÏÐßÁÓÇβ öáì¢îïäå¾îäßöáìõå©» > > -- > Yusuke ENDOH <mame / tsg.ne.jp> > > -- Rick DeNatale Blog: http://talklikeaduck.denhaven2.com/ Twitter: http://twitter.com/RickDeNatale WWR: http://www.workingwithrails.com/person/9021-rick-denatale LinkedIn: http://www.linkedin.com/in/rickdenatale