Hi Matz,

These guidelines sound very reasonable. Thank you for providing them.

Can I make one suggestion: please, please make test cases mandatory
for all patches.

Unless it is pure refactoring, which I suggest would be quite rare,
the patch *must* change something. So the author must have had some
Ruby code that did one thing, then after the patch, the Ruby code does
something else. I believe making the test requirement mandatory is not
too much to ask of patch authors.

Thanks,
Brian

On Wed, Aug 26, 2009 at 6:06 AM, Yukihiro Matsumoto<matz / ruby-lang.org> wrote:
> Hi,
>
> Sometimes we laze core developers have procrastinated to review
> submitted patches, been late to merge patchs, and frustrated
> submitters.  ¨Βθατ§υξζοςτυξατζοβοτθ σιδε ¨Βεςε§τθηυιδεμιξ> to avoid such miscommunication.
>
>  one modification per a patch
>
> This is the biggest issue for most deferred patches.  ¨Βθεωο> submit a patch that fix multiple bugs (and add features) at once,
> we have to separate them before applying it.  ¨Βισ λιξδθαςδ τασλ
> for us, busy developers, so this kind of patches tend to be
> deferred.  ¨Ββιπατγθεπμεασε>
>  more description
>
> Sometimes mere patches do not describe problems that fix.  ¨Βεττε> description (a problem that fix, precondition, platform, etc.)
> would help a patch to be merged earlier.
>
>  diff to the latest
>
> Your problem might have been fixed in the latest.  ¨Βτθγοδε
> might be totally different.  ¨Βεζοςσυβνιττιξη πατγθ¬ τςζετγ> the latest (trunk for 1.9, ruby_1_8 for 1.8) from Subversion,
> please.
>
>  diff -u
>
> We perefer diff -u style unified diff patches to diff -c or any
> other style of patches.  ¨Βθεαςζαεασιες το ςεφιεχ ¨Βξο> send modifed files, we don't want to make diff by ourselves.
>
>  (optional) test cases
>
> a patch to test cases (preferably in a patch to test/*/test_*.rb)
> would help us understand the patch and your intention.
>
> We might move to git style push/pull in the future.  ¨Βυτ υξτιτθεξ> the above guideline would help you to avoid your frustration.
>
> Thank you.
>
>
>  ¨Βατϊ®
>
>