> On Thu, May 29, 2008 at 1:52 AM, Eric Hodel 
> <drbrain / segment7.net> wrote:
> > On May 28, 2008, at 19:48 PM, Giancarlo F Bellido wrote:
> >
> >> I managed to install wxruby and compile zlib extension using this 
> >> patch in ruby trunk. Using zlib 1.2.3 (zlib1.lib) and removing the 
> >> hack in tar_input.rb. Tested in windows XP SP3 MSVC8(2005) 
> and ubuntu 
> >> linux using zlib1g-dev package. Anyone knows if the tar_input.rb 
> >> workaround still works in other systems?
> >
> > Why did you remove the workaround in tar_input.rb?  I don't see how 
> > the second half of your patch would affect it.
> >
> > I seem to recall the hack in tar_input.rb exists for MSVC6. 
>  I don't 
> > recall any known way to reproduce it.  Something in the gzip header 
> > would cause inflate to fail incorrectly.
> >
> > Since gzip is just an extra 10 byte header added to the 
> front of the 
> > inflate algorithm, there should be no reason to remove the hack.
> >
> 
> Also, I'll like to add that I've seen the inflate issue only 
> with older ruby-zlib extension that was bundled with ruby source code.
> Latest trunk code (and ruby_1_8 branch) ships with updated 
> ruby-zlib 0.6.0 that solved this issue (afaik, could be wrong).
> 
> Previous One-Click Installer used to replace bundled 
> ruby-zlib with the update, but latest didn't require that 
> hack and still, everything worked without problems for builds 
> with VC6/GCC on Windows.
> 
> Is there another reason for this to be included? I'm aware 
> that if you build zlib by yourself you need to name it zlib1, 
> what is exactly half of your patch does.
> 
> Is there any other reason you wanted to comment out that? 
> I'll love to know why the workaround is no longer needed.
> 
> Regards,
> --
> Luis Lavena
> AREA 17
> -
> Human beings, who are almost unique in having the ability to 
> learn from the experience of others, are also remarkable for 
> their apparent disinclination to do so.
> Douglas Adams
> 
> 

There is no need to remove the patch for older versions, the problem
was that it was seg faulting in my system and I had to remove it to
make it work. I'm still trying to find out why this happened. I
think I went too far removing it. I should've added the msvc 
detection code to the if statement. Now that's obviously going to make
things a little slower. What is the best way to handle this?