On May 29, 2008, at 05:39 AM, Luis Lavena wrote:
> On Thu, May 29, 2008 at 1:52 AM, Eric Hodel <drbrain / segment7.net>  
> wrote:
>> On May 28, 2008, at 19:48 PM, Giancarlo F Bellido wrote:
>>> I managed to install wxruby and compile zlib extension using this  
>>> patch in
>>> ruby trunk. Using zlib 1.2.3 (zlib1.lib) and removing the hack in
>>> tar_input.rb. Tested in windows XP SP3 MSVC8(2005) and ubuntu  
>>> linux using
>>> zlib1g-dev package. Anyone knows if the tar_input.rb workaround  
>>> still
>>> works
>>> in other systems?
>>
>> Why did you remove the workaround in tar_input.rb?  I don't see how  
>> the
>> second half of your patch would affect it.
>>
>> I seem to recall the hack in tar_input.rb exists for MSVC6.  I  
>> don't recall
>> any known way to reproduce it.  Something in the gzip header would  
>> cause
>> inflate to fail incorrectly.
>>
>> Since gzip is just an extra 10 byte header added to the front of  
>> the inflate
>> algorithm, there should be no reason to remove the hack.
>>
>
> Also, I'll like to add that I've seen the inflate issue only with
> older ruby-zlib extension that was bundled with ruby source code.
> Latest trunk code (and ruby_1_8 branch) ships with updated ruby-zlib
> 0.6.0 that solved this issue (afaik, could be wrong).
>
> Previous One-Click Installer used to replace bundled ruby-zlib with
> the update, but latest didn't require that hack and still, everything
> worked without problems for builds with VC6/GCC on Windows.
>
> Is there another reason for this to be included? I'm aware that if you
> build zlib by yourself you need to name it zlib1, what is exactly half
> of your patch does.
>
> Is there any other reason you wanted to comment out that? I'll love to
> know why the workaround is no longer needed.

In that case, I think it needs to stay in until the versions of one- 
click that have an older ruby-zlib are no longer supported by RubyGems.