Patches item #1909, was opened at 2005-05-13 11:19 You can respond by visiting: http://rubyforge.org/tracker/?func=detail&atid=1700&aid=1909&group_id=426 Category: Ruby1.8 >Group: v1.8.x Status: Open Resolution: None Priority: 3 Submitted By: Daniel Berger (djberg96) Assigned to: Nobody (None) Summary: -Wall -W patch: bignum.c Initial Comment: --- bignum.orig Fri May 13 11:50:21 2005 +++ bignum.c Fri May 13 11:56:54 2005 @@ -101,7 +101,7 @@ VALUE x; { if (!FIXNUM_P(x)) { - long len = RBIGNUM(x)->len; + unsigned long len = RBIGNUM(x)->len; BDIGIT *ds = BDIGITS(x); while (len-- && !ds[len]) ; @@ -135,7 +135,7 @@ unsigned long n; { BDIGIT_DBL num = n; - long i = 0; + unsigned long i = 0; BDIGIT *digits; VALUE big; @@ -223,7 +223,7 @@ { unsigned LONG_LONG q; long neg = 0; - long i; + unsigned long i; BDIGIT *digits; VALUE big; @@ -324,8 +324,7 @@ char sign = 1, nondigit = 0; int c; BDIGIT_DBL num; - long len, blen = 1; - long i; + unsigned long i, len, blen = 1; VALUE z; BDIGIT *zds; @@ -455,7 +454,7 @@ z = bignew(len, sign); zds = BDIGITS(z); for (i=len;i--;) zds[i]=0; - while (c = *str++) { + while ((c = *str++)) { if (c == '_') { if (badcheck) { if (nondigit) goto bad; @@ -544,7 +543,7 @@ unsigned LONG_LONG n; { BDIGIT_DBL num = n; - long i = 0; + unsigned long i = 0; BDIGIT *digits; VALUE big; Everything is still good: >ruby test_bignum.rb Loaded suite test_bignum Started ... Finished in 0.505683 seconds. 3 tests, 164 assertions, 0 failures, 0 errors ---------------------------------------------------------------------- Comment By: Tom Copeland (tom) Date: 2006-04-26 17:57 Message: Testing to ensure comments still work for logged in users... ---------------------------------------------------------------------- Comment By: Tom Copeland (tom) Date: 2006-04-26 17:55 Message: Crikey, there was another bug - Artifact.addMessage() wasn't checking for allowAnon(). Bleah! Ok, let's see how this works now... tom ---------------------------------------------------------------------- Comment By: Tom Copeland (tom) Date: 2006-04-26 12:39 Message: Hm. Spam is still appearing... odd. Must be something else. I'm monitoring this patch now and will keep cleaning it up until I can figure out what's up. Tom ---------------------------------------------------------------------- Comment By: Tom Copeland (tom) Date: 2006-04-26 06:34 Message: Done. No more 'enter an email address' workaround. Spammers begone! tom ---------------------------------------------------------------------- Comment By: Tom Copeland (tom) Date: 2006-04-26 06:31 Message: Hm, looks like spammers have figured out the "enter an email address" thing, removing that now... tom ---------------------------------------------------------------------- Comment By: Nobody (None) Date: 2006-04-24 10:55 Message: test ---------------------------------------------------------------------- You can respond by visiting: http://rubyforge.org/tracker/?func=detail&atid=1700&aid=1909&group_id=426