On Thu, 15 Mar 2007 21:08:03 +0900, Sylvain Joyeux <sylvain.joyeux / m4x.org> wrote:
>> Which set of patches do you think should be committed?  The former to
>> ruby_1_8 and the latter to ruby_1_8_6?
> The latter patches must be applied to 1.8.6, since for now 1.8.6 with
> the 'new' thread support is unusable for multi-threaded programs.
> 
> The former patches may not be applied at all. According to mental, it
> breaks compatibility (well, in my POV and mental's, it breaks poorly written
> programs ...). If you want to apply these changes, tell me so that I
> rewrite the patches, the changes I made are quite ugly ...
> 
> Moreover, you should add fastthread's test suite to ruby's own, and merge
> in it the tests I wrote for the particular issues fixed by these patches
> (test_thread.rb)

FWIW, I agree with Sylvain on all these points.  The bugs addressed by the two necessary patches are subtle in manifestation (so many people have not noticed), but the locking primitives are simply not reliable unless they are addressed.

-mental